RFR 8241073: Pre-generated Stubs for javax.management, Activation, Naming
Roger Riggs
Roger.Riggs at oracle.com
Mon Mar 16 16:34:16 UTC 2020
Hi Erik,
I was thinking that was a separate step, but can pull it in.
(And there's something in spec.gmk.in.)
Roger
On 3/16/20 12:22 PM, Erik Joelsson wrote:
> Hello Roger,
>
> There is more to be removed in the makefiles.
>
> This file should also be removed:
>
> make/CompileInterimRmic.gmk
>
> In make/Main.gmk, all the targets concerning rmic needs to be removed
> as well as any dependencies declared that involves them. Searching for
> "rmic" should find all relevant lines.
>
> /Erik
>
> On 2020-03-16 09:02, Roger Riggs wrote:
>> Please review adding pre-generated RMI stub classes to the jdk repo
>> and the removal of make files supporting the specific APIs.
>>
>> It removes a dependency on build time generation invoking RMIC.
>> RMIC was deprecated in JDK 13 [1].
>>
>> The source files have been edited to remove or suppress compilation
>> warnings.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~rriggs/webrev-stubs-classes-8241073/
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8241073
>>
>>
>> Thanks, Roger
>>
>> p.s. A future change will remove the interim build steps
>>
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8217412
More information about the build-dev
mailing list