RFR: JDK-8241463 Move build tools to respective modules

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon Mar 30 12:13:50 UTC 2020



On 2020-03-28 10:34, Weijun Wang wrote:
>> On Mar 24, 2020, at 3:03 AM, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
>>
>> I have also moved the build tools to the org.openjdk.buildtools.* package name space (inspired by Skara), instead of the strangely named build.tools.* name space.
> Is this really necessary? Skara is a standalone tool that have a public interface, but the build tools are entirely internal. They can even be non public.
Well, no, of course it is not *necessary*. We can move the tools without 
changing their package. Or we can change their package without moving 
them. Or we can do nothing.

However, I think it would be sensible to do so. It will clarify that the 
tools are build tools written for the openjdk project. And it will make 
us walk the walk, not just talk the talk, by adhering to the 
long-standing standards of naming packages. Like, really, what kind of 
package name is "build.tools.*"??? It just sucks on so many levels. Why 
not even "buildtools.*"? What on earth is that dot doing there? It's not 
like we have "build.non-tools.*" ...

Since we'd be moving the files anyway, the cost of changing the package 
naming is negligible, so I think it's good to use this chance to fix it.

/Magnus
>
> --Max
>




More information about the build-dev mailing list