RFR: JDK-8241421 Cleanup handling of jtreg

[Erik Joelsson]

Looks good to me.

Note, the changes in jib-profiles.js will not change any behavior, but 
being explicit is better than trusting defaults.

/Erik

On 2020-03-30 07:49, Magnus Ihse Bursie wrote:
> On 2020-03-23 14:06, Erik Joelsson wrote:
>> Hello,
>>
>> On 2020-03-23 02:21, Magnus Ihse Bursie wrote:
>>> We're doing some odd things in the build system for jtreg, most of 
>>> it left-overs from the older build systems.
>>>
>>> We have no need for JTREGEXE and it should be removed. We should 
>>> also use the standard naming pattern of JTREG_HOME.
>>
>> The environment variable name JT_HOME is defined by Jtreg itself so I 
>> think it makes sense to use that. Configure is still honoring it, but 
>> run-test-prebuilt is not. We can of course use a different variable 
>> name internally, but I don't really see the reason as JT_HOME is the 
>> generally accepted one.
>>
>> In jib-profiles.js, the configure_args for jtreg were not specified 
>> as they were generated by default (a feature you requested way back 
>> when jib was initially designed). I don't mind it being explicitly 
>> set though. You can use "home_path" to have jib automatically find 
>> the single "jtreg" subdir inside the archive.
>>
>> Adding $JT_HOME/bin to the path is done to support (the rarely used) 
>> "jib run" command. It enables you to have jib provide an environment 
>> for running a command directly, such as jtreg. I don't want that 
>> removed. For the same reason, I want JT_HOME to remain globally set 
>> as the jtreg launcher script could otherwise pick up a different 
>> JT_HOME from the users environment.
> I have now updated the patch to remove the rename from JT_HOME to 
> JTREG_HOME, and will be saving that for a separate bug when Jon has 
> implemented the rename in jtreg and we have upgraded to use that jtreg.
>
> That means that the current fix is more or less just "stop using 
> JTREGEXE". I should perhaps rename the bug to reflect this.
>
> I hope I understood your comments about jib-profiles.js correctly.
>
> Updated webrev: 
> http://cr.openjdk.java.net/~ihse/JDK-8241421-cleanup-jtreg/webrev.02
>
> /Magnus
>>
>> /Erik
>>
>>>
>>> The test in BuildFailureHandler.gmk is a bit different -- it is 
>>> supposed to fail. I have run it both with and without the patch, and 
>>> verified that the test result and test log are basically the same, 
>>> except for normal runtime variance like time stamps and certain 
>>> randomness. I have also verified that testing through the Oracle CI 
>>> system still works as expected.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8241421
>>> WebRev: 
>>> http://cr.openjdk.java.net/~ihse/JDK-8241421-cleanup-jtreg/webrev.01
>>>
>>> /Magnus
>