RFR: 8243656: Shell built-in test in configure depends on help
Erik Joelsson
erik.joelsson at oracle.com
Tue May 5 15:24:36 UTC 2020
Looks good to me.
/Erik
On 2020-05-05 08:15, Severin Gehwolf wrote:
> Hi,
>
> Could I please get a review of this trivial change? Apparently using
> the help builtin for determining whether or not a builtin is available
> is not a good idea. A more portable way to do this is to use "command
> -v" or "type". Thanks to Michael Zucchi for contributing this fix.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8243656
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8243656/02/webrev/
>
> Testing: Local builds. jdk/submit.
>
> Thoughts?
>
> Thanks,
> Severin
>
More information about the build-dev
mailing list