RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

[Mikael Vidstedt]

> On May 4, 2020, at 12:44 AM, John Paul Adrian Glaubitz <glaubitz at physik.fu-berlin.de> wrote:
> 
> On 5/4/20 9:39 AM, John Paul Adrian Glaubitz wrote:
>> I haven't looked at the changes yet, but please make sure you don't kill the
>> possibility to build Zero on SPARC on Linux because that should still work
>> without many extra ado.
> This change should be dropped from make/autoconf/platform.m4:
> 
> @@ -148,22 +148,10 @@
>       VAR_CPU=sh
>       VAR_CPU_ARCH=sh
>       VAR_CPU_BITS=32
>       VAR_CPU_ENDIAN=little
>       ;;
> -    sparc)
> -      VAR_CPU=sparc
> -      VAR_CPU_ARCH=sparc
> -      VAR_CPU_BITS=32
> -      VAR_CPU_ENDIAN=big
> -      ;;
> -    sparcv9|sparc64)
> -      VAR_CPU=sparcv9
> -      VAR_CPU_ARCH=sparc
> -      VAR_CPU_BITS=64
> -      VAR_CPU_ENDIAN=big
> -      ;;
>     *)
>       AC_MSG_ERROR([unsupported cpu $1])
>       ;;
>   esac
> ])

Is that the only part that needs to be preserved for linux/sparc+zero? Nothing needed in the rest of the make files, source code, tests, etc.?

> And wouldn't it make sense to keep this change for the future for the
> future removal of other architectures?
> 
> @@ -564,29 +524,10 @@
>   PLATFORM_EXTRACT_TARGET_AND_BUILD
>   PLATFORM_SETUP_TARGET_CPU_BITS
>   PLATFORM_SET_MODULE_TARGET_OS_VALUES
>   PLATFORM_SET_RELEASE_FILE_OS_VALUES
>   PLATFORM_SETUP_LEGACY_VARS
> -  PLATFORM_CHECK_DEPRECATION
> -])
> -
> -AC_DEFUN([PLATFORM_CHECK_DEPRECATION],
> -[
> -  UTIL_ARG_ENABLE(NAME: deprecated-ports, DEFAULT: false,
> -      RESULT: ENABLE_DEPRECATED_PORTS,
> -      DESC: [suppress the error when configuring for a deprecated port])
> -
> -  if test "x$OPENJDK_TARGET_OS" = xsolaris || \
> -      (test "x$OPENJDK_TARGET_CPU_ARCH" = xsparc && \
> -      test "x$with_jvm_variants" != xzero); then
> -    if test "x$ENABLE_DEPRECATED_PORTS" = "xtrue"; then
> -      AC_MSG_WARN([The Solaris and SPARC ports are deprecated and may be removed in a future release.])
> -    else
> -      AC_MSG_ERROR(m4_normalize([The Solaris and SPARC ports are deprecated and may be removed in a
> -        future release. Use --enable-deprecated-ports=yes to suppress this error.]))
> -    fi
> -  fi
> ])
> 
> AC_DEFUN_ONCE([PLATFORM_SETUP_OPENJDK_BUILD_OS_VERSION],
> [
>   ###############################################################################


What are you planning on removing? ;)

Jokes aside - that logic is not complex enough to motivate having around just in case. If we need to reintroduce it we can always go back and get some inspiration from the VCS history.

Cheers,
Mikael

> 
> Adrian
> 
> -- 
> .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer - glaubitz at debian.org
> `. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
>  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913