RFR(XS): 8244756: Build broken with some awk version after JDK-8244248

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon May 11 17:49:19 UTC 2020


On 2020-05-11 18:44, Liu, Xin wrote:
> Hi, Martin and Magnus,
>
> Thank you to fix this problem. sorry, I didn't realize that awk program is less portable.
> Your script looks good to me.
>
> Why it works by reordering \._\- in []. Is it the only potential issue?
It's an old trick. If you have a range, e.g. a-z, then "-" is 
interpreted as the range separator.  So if you wanted to include a 
literal "-" in a []  regex set, you had to put it first or last, since 
then it could not be part of a range. The ability to escape - using \ is 
much newer, and apparently not supported on AIX.

/Magnus

>
> For your information, the reason I added '-' because I found the suffix '-internal' when you build from openjdk source directly.
> "openjdk version "15-internal" 2020-09-15"
>
> thanks,
> --lx
>
>
> On 5/11/20, 9:26 AM, "build-dev on behalf of Magnus Ihse Bursie" <build-dev-bounces at openjdk.java.net on behalf of magnus.ihse.bursie at oracle.com> wrote:
>
>      CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
>      On 2020-05-11 18:17, Doerr, Martin wrote:
>      >
>      > Hi Magnus,
>      >
>      > thank you for proposing a fix which allows building with old awk on
>      > AIX. Works fine.
>      >
>      > Here’s the webrev:
>      >
>      > http://cr.openjdk.java.net/~mdoerr/8244756_AIX_fix_awk_expr/webrev.00/
>      >
>      > Would you like to be mentioned as author?
>      >
>      Whatever. :) If you want.
>
>      /Magnus
>      >
>      > Best regards,
>      >
>      > Martin
>      >
>
>




More information about the build-dev mailing list