[8u] RFR(XS): 8233880: Support compilers with multi-digit major version numbers

[Andrew Hughes]

On 08/05/2020 14:17, Severin Gehwolf wrote:
> Hi,
> 
> Please review this OpenJDK 8u backport of JDK-8233880. It's a
> one-liner change which updates the toolchain.m4 code so as to
> recognize multi-digit GCC versions. For example Fedora 32 comes
> with GCC 10 and falls afoul this check. As a result, a configure
> warning is being produced and crucial flags won't get added for
> compilation. This results in a broken build on such systems.
> 
> Details are in:
> https://bugs.openjdk.java.net/browse/JDK-8244538
> 
> The original JDK 14 patch doesn't apply cleanly post path-
> unshuffeling, because even though JDK-8151841[1] is in 8u,
> JDK-8034788[2] later regressed the
> COMPILER_VERSION_NUMBER sed expression to its prior
> JDK-8151841 form. After this patch, this will be corrected again
> and will include JDK-8233880 changes.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8233880
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8233880/01/webrev/
> 
> Testing: Build prior this patch on F32 with -fcommon (crashes on java
>          -version). Passes after.
> 
> Thoughts?
> 
> Thanks,
> Severin
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8151841
> [2] https://bugs.openjdk.java.net/browse/JDK-8034788
> 

That JDK-8034788 seems to have regressed quite a lot :-(

Change looks fine. I was able to do a clean generation of configure, so
I've approved and pushed this.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222