RFR: JDK-8240228 "make hotspot-ide-project" on Windows creates a Visual Studio project with empty preprocessor defines

[Magnus Ihse Bursie]

After JDK-8239450 (Overhaul JVM feature handling in configure), the 
Hotspot Visual Studio project creator did not properly pick up compiler 
defines.

This turned out to be due to it hard-coding JVM_VARIANT to client (which 
is most often not built), and thus it got not JVM features for client, 
since none were defined.
I changed this hack to a slightly better, which uses server instead. 
(While technically we can build without server, it's not a likely 
configuration, and users of the IDE target just needs to be aware of this.)

Bug: https://bugs.openjdk.java.net/browse/JDK-8240228
Patch inline:
diff --git a/make/hotspot/ide/CreateVSProject.gmk 
b/make/hotspot/ide/CreateVSProject.gmk
--- a/make/hotspot/ide/CreateVSProject.gmk
+++ b/make/hotspot/ide/CreateVSProject.gmk
@@ -35,8 +35,8 @@
    # The next part is a bit hacky. We include the CompileJvm.gmk to be
    # able to extact flags, but we do not wish to execute the rules.

-  # Use client as base for defines and includes
-  JVM_VARIANT=client
+  # Use server as base for defines and includes
+  JVM_VARIANT=server

    include HotspotCommon.gmk
    include lib/CompileJvm.gmk

/Magnus