RFR: JDK-8244966: Add .vscode to .hgignore

Erik Joelsson erik.joelsson at oracle.com
Mon May 18 21:04:32 UTC 2020


Looks good.

/Erik

On 2020-05-18 13:55, Lemmond, Dan wrote:
> Hi,
>
> Please find the updated review here: http://cr.openjdk.java.net/~phh/8244966/webrev.02/
>
> I have added the .vscode directory to the .gitignore as well, keeping both the .hgignore and .gitignore in sync.
>
> Testing was re-conducted and I verified that the .vscode directory is still ignored. Please let me know if there are any other corrections.
>
> Thanks,
> Dan
>   
>
> On 5/16/20, 12:38 AM, "Magnus Ihse Bursie" <magnus.ihse.bursie at oracle.com> wrote:
>
>      On 2020-05-16 01:06, Lemmond, Dan wrote:
>      > Hi,
>      >
>      > This is my first review request so apologies for any missteps or inconsistencies.
>      >
>      > JBS: https://bugs.openjdk.java.net/browse/JDK-8244966
>      > Webrev: http://cr.openjdk.java.net/~phh/8244966/webrev.01/
>      >
>      > Please review this change that adds the .vscode directory to .hgignore, similar to the .idea directory. This directory is generated by various Visual Studio Code plugins during development.
>      >
>      > Testing:
>      > Local testing done, verified that .vscode/ no longer shows up when running hg status.
>      We now also have a .gitignore that should be kept in lockstep with
>      .hgignore. Please update it as well.
>      
>      /Magnus
>      >
>      > Thanks,
>      > Dan
>      
>      
>



More information about the build-dev mailing list