[8u] RFR(XS): 8243059: Build fails when --with-vendor-name contains a comma

[Andrew Hughes]

On 07/05/2020 13:22, Severin Gehwolf wrote:
> Hi,
> 
> Could I please get a review of this OpenJDK 8u backport for JDK-
> 8243059? The build system is wildly different to JDK 11 and later, thus
> is the patch. In turns out on JDK 8, SetupLauncher isn't using eval()
> so the evaluation of the comma too early isn't an issue there. However,
> on JDK 8u, the same issue is present when COMPANY_NAME is being
> evaluated too early in SetupArchive. COMPANY_NAME may contain a comma
> an that breaks the embedded rule for creating the jars.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8243059
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8243059/jdk8/01/webrev/
> 
> Testing: building with --with-vendor-name="foo, bar". Fails before,
> passes after patch.
> 
> Thoughts?
> 
> Thanks,
> Severin
> 

Looks good to me. Thanks.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222