RFR: JDK-8255732: OpenJDK fails to build if $A is set to a value with spaces

Magnus Ihse Bursie ihse at openjdk.java.net
Mon Nov 2 15:03:02 UTC 2020


On Mon, 2 Nov 2020 14:40:35 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> We have at least one java file with a '$' in the name. As we have learned over the years, having $ in unexpected places quickly leads to unexpected behavior in a shell/make based build. In this case it's our override mechanism of java files that needs protection against expanding such occurrences of $.

Looks good to me.

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1007



More information about the build-dev mailing list