RFR: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build [v4]
Andrew Haley
aph at openjdk.java.net
Mon Nov 2 17:45:57 UTC 2020
On Mon, 2 Nov 2020 17:05:19 GMT, Bernhard Urban-Forster <burban at openjdk.org> wrote:
>> @lewurm Open a new JBS issue with the bug. If you can find a fix in a short amount of time (which I would believe should be possible; probably just need a proper cast) it's acceptable to fix it directly. What amounts to a "short amount of time" is left to reasonable judgement; minutes to hours are okay, days are not.
>>
>> Otherwise, create an anti-delta (revert changeset) to back out your changes, and open yet another JBS issue for re-implementing them correctly.
>>
>> In this case, an alternative short-term fix could also be to remove the assert instead of backing out the entire patch.
>
> https://github.com/openjdk/jdk/pull/1013
> @lewurm
> This patch seems to break on linux-aarch64 with gcc:
Builds cleanly on Linux/GCC or me.
-------------
PR: https://git.openjdk.java.net/jdk/pull/530
More information about the build-dev
mailing list