RFR: 8254827: JVMCI: Enable it for Windows+AArch64 [v3]

Mon Nov 2 20:08:03 UTC 2020

On Mon, 2 Nov 2020 19:33:39 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Bernhard Urban-Forster has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - add missing precompiled.hpp include
>>  - Merge remote-tracking branch 'upstream/master' into 8254827-enable-jvmci-win-aarch64
>>  - rename argument to canUsePlatformRegister
>>  - comment for platformRegister
>>  - 8254827: JVMCI: Enable it for Windows+AArch64
>>    
>>    Use r18 as allocatable register on Linux only.
>>    
>>    A bootstrap works now (it has been crashing before due to r18 being allocated):
>>    ```console
>>    $ ./windows-aarch64-server-fastdebug/bin/java.exe -XX:+UnlockExperimentalVMOptions -XX:+UseJVMCICompiler -XX:+BootstrapJVMCI -version
>>    Bootstrapping JVMCI................................. in 17990 ms
>>    (compiled 3330 methods)
>>    openjdk version "16-internal" 2021-03-16
>>    OpenJDK Runtime Environment (fastdebug build 16-internal+0-adhoc.NORTHAMERICAbeurba.openjdk-jdk)
>>    OpenJDK 64-Bit Server VM (fastdebug build 16-internal+0-adhoc.NORTHAMERICAbeurba.openjdk-jdk, mixed mode)
>>    ```
>>    
>>    Jtreg tests `test/hotspot/jtreg/compiler/jvmci` are passing as well.
>
> make/autoconf/jvm-features.m4 line 309:
> 
>> 307:     if test "x$OPENJDK_TARGET_CPU" = "xx86_64"; then
>> 308:       AC_MSG_RESULT([yes])
>> 309:     elif test "x$OPENJDK_TARGET_CPU" = "xaarch64"; then
> 
> You are missing the same change for JVM_FEATURES_CHECK_JVMCI.
> Unless it is done intentionally.

It's done a couple lines below: https://github.com/openjdk/jdk/pull/685/files#diff-a09b08bcd422d0a8fb32a95ccf85051ac1e69bef2bd420d579f74d8efa286d2fL343

Or do you mean something else?

-------------

PR: https://git.openjdk.java.net/jdk/pull/685