RFR: 8255128: linux x86 build failure with libJNIPoint.c

[Magnus Ihse Bursie]

On Mon, 2 Nov 2020 18:36:32 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Add 32-bit-safe version of jlong <-> casts to libJNIPoint.c
> 
> This removes the reported warning.
> 
> Note that the _LP64 macro was not being propagated to the benchmark native libraries on Windows. The comment says that this is due to pack200, but since this has been removed [1], it seemed safe to propagate the macro now (backed up by testing).
> 
> CC'ing hotspot-runtime since I know some people there were looking forward to having this fixed.
> 
> Testing: tier1-3
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8232022

Changes requested by ihse (Reviewer).

make/autoconf/flags-cflags.m4 line 667:

> 665: 
> 666:   if test "x$FLAGS_CPU_BITS" = x64; then
> 667:     if test "x$FLAGS_OS" = xlinux || test "x$FLAGS_OS" = xmacosx || test "x$FLAGS_OS" = xwindows; then

At this point, you're almost testing for all supported OSes.  :) I can only think of AIX that does not match this if clause. I think it would be better to just remove the if and always define _LP64=1 on 64-bit platforms. 

@simonis Would that be OK for AIX?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1017