RFR: 8255128: linux x86 build failure with libJNIPoint.c

[Jorn Vernee]

On Tue, 3 Nov 2020 19:16:02 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Thanks for the suggestion.
>> 
>> Note the code that adds _LP64 for the JVM (below):
>> 
>>     if test "x$FLAGS_OS" != xaix; then
>>       # xlc on AIX defines _LP64=1 by default and issues a warning if we redefine it.
>>       $1_DEFINES_CPU_JVM="${$1_DEFINES_CPU_JVM} -D_LP64=1"
>>     fi
>> 
>> So, it seems xlc/aix explicitly does _not_ want this macro defined?
>> 
>> I think we could reuse that if-block to add `-D_LP64=` to both `1_DEFINES_CPU_JDK`, and `1_DEFINES_CPU_JVM` though, and remove the first one that checks for linux/mac/windows.
>
> Yes, that sounds good. I did not notice this (still not used to github reviews, which I think has too little context by default).

Ok, will do. (FWIW, you can expand the context of the diff with the arrow buttons on the left side of the view. Above or below the line numbers)

-------------

PR: https://git.openjdk.java.net/jdk/pull/1017