RFR: 8255128: linux x86 build failure with libJNIPoint.c [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Tue Nov 3 20:42:58 UTC 2020
On Tue, 3 Nov 2020 20:37:07 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Add 32-bit-safe version of jlong <-> casts to libJNIPoint.c
>>
>> This removes the reported warning.
>>
>> Note that the _LP64 macro was not being propagated to the benchmark native libraries on Windows. The comment says that this is due to pack200, but since this has been removed [1], it seemed safe to propagate the macro now (backed up by testing).
>>
>> CC'ing hotspot-runtime since I know some people there were looking forward to having this fixed.
>>
>> Testing: tier1-3
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8232022
>
> Jorn Vernee has updated the pull request incrementally with two additional commits since the last revision:
>
> - Collapse both _LP64 if blocks in flags-cflags.m4
> - Use jlong.h macros instead of spinning new ones
This looks better.
-------------
Marked as reviewed by coleenp (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1017
More information about the build-dev
mailing list