RFR: 8247872: Upgrade HarfBuzz to the latest 2.7.2 [v2]
Magnus Ihse Bursie
ihse at openjdk.java.net
Thu Nov 5 13:38:57 UTC 2020
On Thu, 5 Nov 2020 11:24:28 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>>> I'm just a bit curious about the added, empty, `src/java.desktop/share/native/libharfbuzz/abc.txt`...
>>>
>>> If it really is in upstream source, I'm not saying you should remove it. It just looks very odd. It's not a merge artifact?
>>>
>>> (I could not even add review comments to an empty file in github! 😮)
>>
>> oops. that should not have been in that folder. It was me practicing a different white space removal script.
>> I thought I checked for any extraneous files. I'll get rid of it now.
>
> Looks like the build on macOS via GitHub will be broken by this fix?
@mrserb Good catch! Yes indeed, it looks like `range-loop-analysis` needs to be disabled for clang for Xcode 12 to not complain.
-------------
PR: https://git.openjdk.java.net/jdk/pull/993
More information about the build-dev
mailing list