RFR: 8256354: Github Action build on Windows should define OS and MSVC versions

Aleksey Shipilev shade at openjdk.java.net
Fri Nov 13 18:38:56 UTC 2020


On Fri, 13 Nov 2020 17:26:28 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> We should be more explicit about OS and compiler versions used in the GitHub Actions builds, to avoid problems caused by unexpected changes to the defaults. This patch changes the OS and MSVC versions used from latest (currently 2019) / default (currently 14.28) to 2019 / 14.27.

Looks good to me. I wondered if https://github.com/marketplace/actions/setup-msbuild could have been used instead, but this is fine as well.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1207



More information about the build-dev mailing list