RFR: 8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing [v2]

[Robin Westberg]

On Fri, 20 Nov 2020 14:39:54 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve naming, fix style issues
>
> .github/workflows/submit.yml line 380:
> 
>> 378:         continue-on-error: true
>> 379: 
>> 380:   linux_x64_hotspot_only:
> 
> This is a weird name for a job that also cross-compiles non-x64 versions. Maybe `linux_aux_builds` or some such?

Yeah this can probably be improved, how about the updated version?

> .github/workflows/submit.yml line 469:
> 
>> 467:           name: transient_jdk-linux-x64_${{ needs.prerequisites.outputs.bundle_id }}
>> 468:           path: ~/jdk-linux-x64
>> 469:         if: steps.build_restore.outcome == 'failure'
> 
> I may be blind, but I don't see any step with id `build_restore` in new file...

It already existed in the step right above so I didn't have to add it.. This follows the same pattern as other artifact downloads (I've seen them fail a fair amount of time in the past).

> .github/workflows/submit.yml line 506:
> 
>> 504:         run: >
>> 505:           sudo qemu-debootstrap
>> 506:           --arch=${{ matrix.debian-arch}}
> 
> Style: `${{ matrix.debian-arch }}` (space before closing braces) -- also in other places.

Ah right, good catch, fixed these.

> .github/workflows/submit.yml line 532:
> 
>> 530:         run: >
>> 531:           bash configure
>> 532:           --with-conf-name=linux-x64-hotspot
> 
> That does not look a proper config name for cross-compiled jobs?

No you are right, I didn't really care since it's not visible anywhere, but can certainly update it a bit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1350