RFR: 8256829: GNU hash style is not available on MIPS

Jie Fu jiefu at openjdk.java.net
Mon Nov 23 08:26:05 UTC 2020


On Sun, 22 Nov 2020 14:47:07 GMT, John Paul Adrian Glaubitz <glaubitz at openjdk.org> wrote:

>> For fun, I tried to build `linux-mips64el-zero-fastdebug`, and it cannot be built, because linker complains:
>> 
>> 
>> collect2: error: ld returned 1 exit status
>> 
>> I believe it is a regression in 16, as GNU hash style was forced with [JDK-8200738](https://bugs.openjdk.java.net/browse/JDK-8200738). The way out is to special-case MIPS hash-style to `sysv`. This enumerates all MIPS targets that `make/autoconf/platform.m4` knows about.
>> 
>> Attention @DamonFool, who must be running into this problem for their MIPS builds?
>> 
>> Testing:
>>  - [x] Linux mipsel zero fastdebug build (requires additional unrelated fixes)
>>  - [x] Linux mips64el zero fastdebug build
>
> Hi Aleksey!
> 
>> For fun, I tried to build `linux-mips64el-zero-fastdebug`, and it cannot be built, because linker complains:
> 
> Thanks for looking to fixing the non-mainstream architectures. I'm surprised we don't need the sigset patch anymore for MIPS, looks like that has been upstreamed already.
> 
> If you are looking into fixing more of such issues, you can have a look at the patches we currently carry in Debian to address various of such issues:
> 
>> https://git.launchpad.net/~openjdk/ubuntu/+source/openjdk/+git/openjdk/tree/debian/patches
> 
> I'm currently busy with LLVM but I'm planning to get more active with OpenJDK in the future and get more of such fixes upstreamed.
> 
> Again, thanks for fixing this. We actually use OpenJDK on MIPS targets in Debian.

@theaoqi and @xiangzhai would you like to verify this fix?
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1374



More information about the build-dev mailing list