RFR: 8256747: GitHub Actions: decouple the hotspot build-only jobs from Linux x64 testing [v2]

Aleksey Shipilev shade at openjdk.java.net
Mon Nov 23 10:02:00 UTC 2020


On Mon, 23 Nov 2020 09:55:34 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> .github/workflows/submit.yml line 526:
>> 
>>> 524:           echo "CC=${{ matrix.gnu-arch }}-linux-gnu${{ matrix.gnu-flavor}}-gcc-10" >> $GITHUB_ENV
>>> 525:           echo "CXX=${{ matrix.gnu-arch }}-linux-gnu${{ matrix.gnu-flavor}}-g++-10" >> $GITHUB_ENV
>>> 526:           echo "cross_flags=--openjdk-target=${{ matrix.gnu-arch }}-linux-gnu${{ matrix.gnu-flavor}} --with-sysroot=${HOME}/sysroot-${{ matrix.debian-arch }}/ --with-toolchain-path=${HOME}/sysroot-${{ matrix.debian-arch }}/ --with-freetype-lib=${HOME}/sysroot-${{ matrix.debian-arch }}/usr/lib/${{ matrix.gnu-arch }}-linux-gnu${{ matrix.gnu-flavor}}/ --with-freetype-include=${HOME}/sysroot-${{ matrix.debian-arch }}/usr/include/freetype2/ --x-libraries=${HOME}/sysroot-${{ matrix.debian-arch }}/usr/lib/${{ matrix.gnu-arch }}-linux-gnu${{ matrix.gnu-flavor}}/" >> $GITHUB_ENV
>> 
>> No chance to break this line by option? It is kinda hard to read and thus verify. It is still okay if we cannot.
>
> Sure, I agree, perhaps just putting that as a separate step would increase readability.

The update looks fine.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1350



More information about the build-dev mailing list