RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow

Thomas Stüfe thomas.stuefe at gmail.com
Mon Nov 23 11:11:25 UTC 2020


Hi Bernhard,

just some drive-by comments.

- 40-50 min builds seem to be excessive for just the hotspot build, do you
know what exactly takes that long? Is this for release and debug each or
both combined?

- Is it worth the cycles to build both release *and* debug? How probable is
it that a non-win-aarch-dev will break one but not the other? I presume
developers on the windows aarch project will have tested the build locally
before pushing.

- fixpath: Having the gh actions download a patch from your personal repos
seems odd

I feel at some point we need to have a talk about the growing number of
platforms in github actions. E.g. which platforms should be mandatory green
before pushing.

I also am unsure about the associated cost for each developer (I know atm
everyone has a free quota, but that is not limitless. If it is eaten up,
strictly speaking one would not be able to push anymore since no submit
tests can be ran until the quota is refilled).

Cheers, Thomas

On Mon, Nov 23, 2020 at 10:41 AM Bernhard Urban-Forster <
burban at openjdk.java.net> wrote:

> This adds the cross-compiled build only, as no Windows+Arm64 machines are
> available on GitHub Action that we could use to run the tests.
>
> Due to cross-compilation a build JDK is required. Initially I added EA
> builds to be downloaded from https://jdk.java.net/16/ and used for that,
> but then I saw how @shipiliv attempted it for the linux cross-compilation
> builds in https://github.com/openjdk/jdk/pull/1147.  That is using the
> JDK image produced by the x64 variant. This however add more stress to the
> "critical path", as now two more jobs depend on the x64 build first.
>
> Let's see how it works out in the long-run. A Windows+AArch64 build takes
> 40-50min.
>
> -------------
>
> Commit messages:
>  - 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow
>
> Changes: https://git.openjdk.java.net/jdk/pull/1379/files
>  Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1379&range=00
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8256657
>   Stats: 164 lines in 1 file changed: 163 ins; 0 del; 1 mod
>   Patch: https://git.openjdk.java.net/jdk/pull/1379.diff
>   Fetch: git fetch https://git.openjdk.java.net/jdk
> pull/1379/head:pull/1379
>
> PR: https://git.openjdk.java.net/jdk/pull/1379
>



More information about the build-dev mailing list