RFR: 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8 [v2]
Aleksey Shipilev
shade at openjdk.java.net
Mon Nov 23 19:58:08 UTC 2020
> If you try to build `linux-mipsel-zero-fastdebug`, this happens:
>
>
>
>
>
>
>
> I think it relates to [JDK-8253970](https://bugs.openjdk.java.net/browse/JDK-8253970) that introduced `atomic_compare_exchange` on those paths, but maybe the issue exists for longer.
>
> Various other reports for build failures like this suggest the binary should link with `libatomic`. GCC's `libatomic` is the library that provides runtime support for atomics not supported in hardware, which seems to include 8-byte CAS for MIPS, but not any other OpenJDK platform.
>
> The alternative would be to massage the otherwise generic Zero code to unimplement the 8-byte CAS.
>
> Attention @DamonFool, who must be running into this problem for their MIPS builds?
>
> Testing:
> - [x] Linux mipsel Zero fastdebug build (together with JDK-8256829 fix)
Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
- Move the library addition to LIB_SETUP_LIBRARIES
- Merge branch 'master' into JDK-8256831-mips-8-byte-cas
- 8256831: MIPS Zero builds fail with undefined __atomic_compare_exchange_8
-------------
Changes: https://git.openjdk.java.net/jdk/pull/1375/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1375&range=01
Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod
Patch: https://git.openjdk.java.net/jdk/pull/1375.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1375/head:pull/1375
PR: https://git.openjdk.java.net/jdk/pull/1375
More information about the build-dev
mailing list