RFR: 8254102: use ProcessHandle::pid instead of ManagementFactory::getRuntimeMXBean to get pid in tests [v2]
    Aleksey Shipilev 
    shade at openjdk.java.net
       
    Wed Oct  7 18:12:20 UTC 2020
    
    
  
On Wed, 7 Oct 2020 18:09:28 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
>> Hi all,
>> 
>> could you please review this small cleanup which replaces
>> `ManagementFactory.getRuntimeMXBean().getName().split("@")[0]` w/ `ProcessHandle.current().pid()` to get current
>> process pid?  Thanks,
>> -- Igor
>
> Igor Ignatyev has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - use Long.toString instead of String.valueOf
>  - remove explicit coversion to String in Suicide.java
Still looks good to me.
-------------
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/534
    
    
More information about the build-dev
mailing list