RFR: 8254173: Add Zero, Minimal hotspot targets to submit workflow [v2]

[Robin Westberg]

On Wed, 7 Oct 2020 16:28:17 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Zero VM and Minimal VM builds are routinely discovering the problems with internal Hotspot dependencies. Mostly because
>> they turn off the whole lot of VM features, and every path that is not guarded by a feature #ifdef or build file list
>> fails.   It would be good to add Zero and Minimal targets to submit workflow.
>> 
>> It seems to add two ~9 minute stages, compared to ~17 minute stage for building no-pch hotspot, and ~33 minutes for
>> full JDK.
>> Attention @rwestberg.
>> 
>> Testing:
>>   - [x] GH workflow still works; see [latest run ](https://github.com/shipilev/jdk/actions/runs/293805791)
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Build with debug and no-pch for zero and minimal

Looks good to me! Adding a few additional shorter build shouldn't increase the total runtime, as the test execution
waits for all builds to be done, so we are limited by the full builds anyway.

One minor comment, perhaps rearrange the description a bit of these new flavors with the differentiating parts first.
GitHub cuts them short in the overview list (see the list on the left at
https://github.com/shipilev/jdk/actions/runs/293805791 for an example) so you can't currently tell which one is which
in the overview without clicking on them.

.github/workflows/submit.yml line 109:

> 107:           - build debug
> 108:           - build hotspot no-pch
> 109:           - build debug hotspot no-pch zero

Suggestion:

          - build hotspot zero no-pch debug

-------------

Marked as reviewed by rwestberg (Committer).

PR: https://git.openjdk.java.net/jdk/pull/546