RFR: 8254175: Build no-pch configuration in debug mode for submit checks [v2]

[Robin Westberg]

On Thu, 8 Oct 2020 07:19:21 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> no-pch configuration is supposed to expose missing include dependencies. But currently it runs with default (release)
>> bits, which misses symbols hidden in debug code. We should consider building it in debug mode.
>> Attention @rwestberg.
>> 
>> Testing:
>>   - [x] GH workflow still works, see the builds in the [latest run](https://github.com/shipilev/jdk/actions/runs/293802758)
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Drop "debug" from the names

Looks good to me! Just a similar comment as in #546, the name is a bit too long now, so perhaps just drop the "debug"
from the description?

Looks good!

.github/workflows/submit.yml line 108:

> 106:           - build release
> 107:           - build debug
> 108:           - build debug hotspot no-pch

Suggestion:

          - build hotspot no-pch

.github/workflows/submit.yml line 113:

> 111:             flags: --enable-debug
> 112:             artifact: -debug
> 113:           - flavor: build debug hotspot no-pch

Suggestion:

          - flavor: build hotspot no-pch

-------------

Marked as reviewed by rwestberg (Committer).

PR: https://git.openjdk.java.net/jdk/pull/547