RFR: 8252407: Build failure with gcc-8+ and asan.

Tue Oct 13 03:17:09 UTC 2020

On Mon, 12 Oct 2020 13:49:52 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Summary: Fix stringop-truncation warnings casused by gcc.
>> 
>> The newer gcc(gcc-8 or higher) would warn for calls to bounded string
>> manipulation functions such as 'strncpy' that may either truncate the
>> copied string or leave the destination unchanged.
>> 
>> The reason is that -fsanitize=address might simply incompatible with
>> -Wstringop-truncation. This patch disables stringop-truncation warning
>> when asan enabled, also disables the defining of _FORTIFY_SOURCE in
>> fastdebug builds for some potential risks.
>
> Looks good to me.  This is what I was expecting to see, based on the previous discussion.

Thank Kim and Magnus for reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/607