RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]
Kevin Rushforth
kcr at openjdk.java.net
Tue Oct 13 23:25:22 UTC 2020
On Tue, 13 Oct 2020 14:48:40 GMT, Andy Herrick <herrick at openjdk.org> wrote:
>> JDK-8252870: Finalize (remove "incubator" from) jpackage
>
> Andy Herrick has updated the pull request incrementally with one additional commit since the last revision:
>
> JDK-8252870: Finalize (remove "incubator" from) jpackage
> - reverting two auto-generated files, and changing module-info to "@since 16"
Looks good. I double-checked all of the file renames and all are exactly as expected. The diffs got a bit confused in a
couple cases, where it thought that a renamed and modified file was copied from somewhere else (see inline comments),
but that can happen given that git doesn't actually track renames and copies).
-------------
Marked as reviewed by kcr (Author).
PR: https://git.openjdk.java.net/jdk/pull/633
More information about the build-dev
mailing list