RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

Maurizio Cimadamore mcimadamore at openjdk.java.net
Thu Oct 22 16:34:28 UTC 2020


On Wed, 21 Oct 2020 19:05:42 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>> 
>>  - Merge branch 'master' into 8254231_linker
>>  - Fix incorrect capitalization in one copyright header
>>  - Update copyright years, and add classpath exception to files that were missing it
>>  - Use separate constants for native invoker code size
>>  - Re-add file erroneously deleted (detected as rename)
>>  - Re-add erroneously removed files
>>  - Merge branch 'master' into 8254231_linker
>>    
>>    - Fix tests
>>  - Fix more whitespaces
>>  - Fix whitespaces
>>  - Remove rejected file
>>  - ... and 15 more: https://git.openjdk.java.net/jdk/compare/cb6167b2...502bd980
>
> Some of this is familiar to me from reviews in the `panama-foreign` repository, but less so than the memory API. I focused on the Java code, and ignored changes that are common with the memory API PR.
> 
> If it helps in can provide a PR in the `panama-foreign` repository addressing editorial comments to the linker API.

I've just uploaded a new iteration which addresses most of @PaulSandoz comments on the API/Java impl.

-------------

PR: https://git.openjdk.java.net/jdk/pull/634



More information about the build-dev mailing list