RFR: 8255352: Archive important test outputs in submit workflow
Aleksey Shipilev
shade at openjdk.java.net
Sat Oct 24 08:17:47 UTC 2020
Currently, we are only archiving `build/*/test-results`. But hs_errs, replays, and test outputs are actually in `build/*/test-support`! Which means once any test fails, we only have the summary of the run, not the bits that would actually help to diagnose the problem.
Archiving the entire test-support seems too much, it yields 50K artifacts available as 1 GB zip archive in GH GUI. On top of that `upload-artifact` does the upload per-file, which takes tens of minutes on 50K files (and I suspect many API calls).
But we can pick up important test outputs selectively and then also compress them. See sample artifact here:
https://github.com/shipilev/jdk/runs/1301540541
It packages the final ZIP like this:
$ unzip -t test-results_.zip
Archive: test-results_.zip
testing: artifact/ OK
testing: artifact/linux-x64-debug_testresults_hs_tier1_common.zip OK
testing: artifact/linux-x64-debug_testsupport_hs_tier1_common.zip OK
...
-------------
Commit messages:
- Upload test artifacts from home
- Fix Windows "zip" and try to skip a few intermediate directories
- Compress testresults/testsupport before uploading
- 8255352: Archive important test outputs in submit workflow
Changes: https://git.openjdk.java.net/jdk/pull/842/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=842&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8255352
Stats: 94 lines in 1 file changed: 85 ins; 2 del; 7 mod
Patch: https://git.openjdk.java.net/jdk/pull/842.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/842/head:pull/842
PR: https://git.openjdk.java.net/jdk/pull/842
More information about the build-dev
mailing list