RFR: 8255412: "Linux x32" should be "Linux x86" in submit workflow

Magnus Ihse Bursie ihse at openjdk.java.net
Tue Oct 27 08:43:20 UTC 2020


On Tue, 27 Oct 2020 06:35:33 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>>> > My rationale is simple: I am playing the whack-a-mole against the ongoing x86_32 regressions here
>>> 
>>> Would it be possible that we add a Travis hook so that commits get tested once before they are merged?
>> 
>> Maybe, but that would be beyond the scope of this PR. These GH actions workflows go the long way already to make pre-integration tests, and they already run and used by OpenJDK contributors. I see immediate value in improving GH workflows, and see no clear estimate how much work would be involved in hooking up Travis, and what the project-wide consequences would be. If you want, open a new bug, prototype the change, discuss it there, and see if that is an acceptable thing to do.
>
> Let me coop this PR to rename x32 -> x86, among other cosmetic changes. Once #830 lands, I'll update x32 -> x86 in those new blocks as well. This way, we can have best of both worlds: x86_32 would start testing, and we would do the follow-ups here.

@shipilev I realize you are eager to have Github run automatic testing on platforms that you care about, but it's not like it's a regression that needs to be taken care of immediately. I strongly prefer to have a correct solution implemented once, before committing, than this piece-meal splitting of what's actually a single issue into three different PRs.

Now, the first one has already gone in, so not much to do about that, but I strongly believe that this and JDK-8255305 should be folded together in a single issue.

-------------

PR: https://git.openjdk.java.net/jdk/pull/869



More information about the build-dev mailing list