RFR: 8255412: "Linux x32" should be "Linux x86" in submit workflow

Tue Oct 27 10:14:21 UTC 2020

On Tue, 27 Oct 2020 09:38:41 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> > Do you mean that you consider #505 and #548 dependent on this bug? If so, I think you misunderstand the purpose of the Github submit testing hook. You can -- and should! -- still do proper testing just as you did before the migration to Github. The Github action hook is a convenience.

> Oh yes, I must be misunderstanding this. Because I thought pre-submit tests were the replacement for jdk-submit functionality, which was the Oracle's requirement for push to shared code. Good to know it had been demoted to mere suggestion.

I did not say it was a "suggestion". I said it was a "convenience". Those two are not the same. As a Committer, it is your responsibility, now and as it always has been, to make sure the code is tested to the best of your abilities.  As a Reviewer, it is your responsibility to make make sure that no significant testing has been left out by the Committer.

> Making sure that product code is correct on x86_32 is more important than making sure the testing code is cosmetically clean.

Thankfully, those two are not orthogonal! The testing for x86 on product changes can proceed just as before the move to Github, and we can make sure to keep the testing code up to the same quality as one should expect.

-------------

PR: https://git.openjdk.java.net/jdk/pull/869