RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package
David Holmes
dholmes at openjdk.java.net
Tue Sep 8 01:13:41 UTC 2020
On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall <github.com+471021+marschall at openjdk.org> wrote:
> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package.
> - I tried to keep code changes to a minimum, eg not change to imports if fully qualified class names are used instead of
> imports. In some cases I did minor reordering of imports to keep them sorted alphabetically.
> - All tier1 tests pass.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.
The changes all look good to me.
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/45
More information about the build-dev
mailing list