RFR: 8252998: ModuleWrapper.gmk doesn't consult include path

Erik Joelsson erik.joelsson at oracle.com
Thu Sep 10 13:14:42 UTC 2020


Hello Adam,

I agree with this change. However, since we moved to github and Skara 
last weekend, you need to post this as a PR. See instructions for 
setting up an OpenJDK workflow in the new Skara world here: 
https://wiki.openjdk.java.net/display/SKARA/Skara

/Erik

On 2020-09-10 02:36, Adam Farley8 wrote:
> Hi All,
>
> Requesting reviews and sponsor for the following change.
>
> A previous change (JDK-8244044) appears to prevent make from checking the
> include dirs for an included gmk file.
>
> This means that you can't override the included file using the include
> dirs, as was previously the case.
>
> This sounds like a bug, and should be fixed.
>
> Thoughts welcome.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8252998
>
> Webrev: http://cr.openjdk.java.net/~afarley/8252998/webrev/
>
> Best Regards
>
> Adam Farley
> IBM Runtimes
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>



More information about the build-dev mailing list