RFR: 8253031: git jcheck complains about invalid tags in jdk repo after fix for JDK-8252844
Erik Helin
ehelin at openjdk.java.net
Fri Sep 11 14:46:15 UTC 2020
On Fri, 11 Sep 2020 14:28:41 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
> In the fix for [JDK-8252844](https://bugs.openjdk.java.net/browse/JDK-8252844) the tags entry in `.jcheck/conf` was
> copied from the Skara Java code. The `` chars were escaped as `\` in the Java String so that it would contain ``. This
> additional level of escape is not needed in the `.jcheck/conf` file, and causes the regex to not be as intended. The
> fix is to replace `\` with `` in the regex.
Looks good Kevin, thanks for fixing!
-------------
Marked as reviewed by ehelin (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/131
More information about the build-dev
mailing list