RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

Bradford Wetmore wetmore at openjdk.java.net
Fri Sep 11 15:20:36 UTC 2020


On Fri, 11 Sep 2020 07:15:26 GMT, Dmitriy Dumanskiy <github.com+1536494+doom369 at openjdk.org> wrote:

>> 1) This is un-necessary churn.
>> 2) I can't even be sure I am finding the ones in my area because there's so much here
>> 3) The ones I can find have no need of whatever performance improvement this might bring.
>> I think this whole PR should be withdrawn, and there may an attempt at measuring the benefits of this for the various
>> cases before submitting in appropriate smaller chunks. But I'll tell you now I don't see a need for the test updates
>> you are making.
>
> Ok, sorry for the distraction.

Our local Santuario maintainer says:

In general, changes to Apache Santuario should also be made at Apache so we stay in sync.

-------------

PR: https://git.openjdk.java.net/jdk/pull/29



More information about the build-dev mailing list