RFR: 8253034: Update symbol generation to accomodate Git as the SCM

Joe Darcy darcy at openjdk.java.net
Tue Sep 15 20:10:42 UTC 2020


On Tue, 15 Sep 2020 13:45:40 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> make/scripts/generate-symbol-data.sh line 66:
>> 
>>> 64: fi;
>>> 65:
>>> 66: if [ "`git status -s .`x" != "x" ] ; then
>> 
>> Just a suggestion: perhaps you want to use the porcelain format here instead of short?
>> https://git-scm.com/docs/git-status#Documentation/git-status.txt---porcelainltversiongt
>
> I agree with @adityamandaleeka, please use `git status --porcelain=v1`. See the git status
> [documentation](https://git-scm.com/docs/git-status#_porcelain_format_version_1) for the specification for the output.

@adityamandaleeka and @edvbld, thanks for the suggestion; I'll update the patch accordingly.

-------------

PR: https://git.openjdk.java.net/jdk/pull/161



More information about the build-dev mailing list