RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v5]
Bernhard Urban-Forster
burban at openjdk.java.net
Thu Sep 24 15:19:13 UTC 2020
On Thu, 24 Sep 2020 04:52:22 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Monica Beckwith has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update orderAccess_windows_aarch64.hpp
>>
>> changing from Acq-reL to Sequential Consistency to avoid compiler reordering when no ordering hints are provided
>
> src/hotspot/share/runtime/stubRoutines.cpp line 397:
>
>> 395: // test safefetch routines
>> 396: // Not on Windows 32bit until 8074860 is fixed
>> 397: #if ! (defined(_WIN32) && defined(_M_IX86)) && !defined(_M_ARM64)
>
> The comment needs updating to refer to Aarch64.
This is actually not needed anymore, as it does work just fine on Windows+Aarch64. Presumably we have added it in the
early days of the port when we haven't figured out exception handling quite yet.
Thanks for catching David.
-------------
PR: https://git.openjdk.java.net/jdk/pull/212
More information about the build-dev
mailing list