RFR: 8248238: Implementation of JEP: Windows AArch64 Support [v6]

David Holmes david.holmes at oracle.com
Fri Sep 25 01:34:10 UTC 2020


Hi Chris, Monica,

On 25/09/2020 1:47 am, Chris Plummer wrote:
> As for the copyright in the new SA files, I believe it is incorrect and needs to include Oracle. There are a number of
> other non-SA files that are new and also have the same copyright issue.

If a file was created completely from scratch then it should just have 
the Microsoft copyright notice. However, if it was copied from an 
existing file and modified, then the existing file's copyright should be 
included and a Microsoft one added if the changes are significant.

But IANAL. :)

Cheers,
David

> I also looked at src/jdk.attach/windows/classes/sun/tools/attach/AttachProviderImpl.java. It looks fine except it needs
> a copyright date update.
> 
> -------------
> 
> Changes requested by cjplummer (Reviewer).
> 
> PR: https://git.openjdk.java.net/jdk/pull/212
> 



More information about the build-dev mailing list