RFR: 8253375: OSX build fails with Xcode 12.0 (12A7209)

Kim Barrett kim.barrett at oracle.com
Fri Sep 25 08:00:48 UTC 2020


> On Sep 25, 2020, at 1:49 AM, Kim Barrett <kbarrett at openjdk.java.net> wrote:
> 
> On Thu, 24 Sep 2020 21:28:01 GMT, Paul Hohensee <phh at openjdk.org> wrote:
> 
>> Please review this small patch to enable the OSX build using Xcode 12.0.
>> 
>> Thanks,
>> Paul
> 
> […]
> 
> I think changing the declaration for locs_buf to any of the following gives
> equivalent behavior to the current code. […]
> 
> […]

Another variant that probably avoids both the warning and avoids any C++14 features:

(4)  union { char data[20 * sizeof(double)]; double align; } locs_buf;
and change (relocInfo*)locs_buf => (relocInfo*)&locs_buf.

> -------------
> 
> Changes requested by kbarrett (Reviewer).
> 
> PR: https://git.openjdk.java.net/jdk/pull/348





More information about the build-dev mailing list