RFR: 8253624: gtest fails when run from make with read-only source directory

[Erik Joelsson]

On Fri, 25 Sep 2020 07:45:34 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

> In an out-of-tree build where the source code is in a read-only location
> several gtests such as LogFileOutput.invalid_file_test_vm will fail
> because they write files to the current working directory.
> 
>   [ RUN ] LogFileOutput.invalid_file_test_vm
>   # To suppress the following error report, specify this argument
>   # after -XX: or in .hotspotrc: SuppressErrorAt=/logTestUtils.inline.hpp:65
>   assert failed: failed to create directory tmplogdir
>   #
>   # A fatal error has been detected by the Java Runtime Environment:
>   #
>   # Internal Error (/mnt/nicgas01-pc/jdk/test/hotspot/gtest/logging/logTestUtils.inline.hpp:65), pid=51470, tid=51470
>   # assert(!failed) failed: failed to create directory tmplogdir
> 
> Run the gtest launcher with the working directory set to the test
> support directory which we know is writable.

That's a nice fix, thanks!

-------------

Marked as reviewed by erikj (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/354