RFR: 8264806: Remove the experimental JIT compiler [v2]
Vladimir Kozlov
kvn at openjdk.java.net
Mon Apr 12 17:22:00 UTC 2021
On Mon, 12 Apr 2021 16:18:32 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Restore Graal Builder image makefile
>> - Merge latest changes from branch 'JDK-8264805' into JDK-8264806
>> - 8264806: Remove the experimental JIT compiler
>
> make/common/Modules.gmk line 68:
>
>> 66:
>> 67: # Filter out Graal specific modules
>> 68: MODULES_FILTER += jdk.internal.vm.compiler
>
> If we are unconditionally filtering out these modules, then why leave the module-info.java files in at all?
We filter out because we can't build Graal anymore. But we need these module-info.java files because JVMCI's module-info.java references them:
https://github.com/openjdk/jdk/blob/master/src/jdk.internal.vm.ci/share/classes/module-info.java#L26
Otherwise we can't build JVMCI which we continue to support.
I filed followup RFE to implement Alan's suggestion to use Module API which will allow to remove these files later:
https://bugs.openjdk.java.net/browse/JDK-8265091
-------------
PR: https://git.openjdk.java.net/jdk/pull/3421
More information about the build-dev
mailing list