RFR: 8259288: Debug build failure with clang-10 due to -Wimplicit-int-float-conversion [v2]

[Hao Sun]

On Tue, 9 Feb 2021 05:17:06 GMT, Hao Sun <haosun at openjdk.org> wrote:

>> Making the conversion explicit would fix it.
>> 
>> Flag '-Wimplicit-int-float-conversion' is first introduced in clang-10.
>> Therefore clang-8 and clang-9 are not affected. The flag with similar
>> functionality in gcc is '-Wfloat-conversion', but it is not enabled by
>> '-Wall' or '-Wextra'. That's why this warning does not appear when
>> building with gcc.
>> 
>> 
>> Note that we have tested with this patch, debug build succeeded with clang-10 on Linux X86-64/AArch64 machines.
>> Note that '--with-extra-cxxflags=-Wno-deprecated-copy' should be added when configuration. It's another issue (See JDK-8258010)
>
> Hao Sun has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use static_cast<double>
>   
>   To match the style in this file, use static_cast to perform type
>   casting.

Ping?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1956