RFR: 8265696 move cds sources [v2]

Ioi Lam iklam at openjdk.java.net
Thu Apr 22 06:18:11 UTC 2021


> The number of CDS source files have grown significantly. To improve modularity, the following files should be moved a new directory, src/hotspot/share/cds.
> 
> - src/hotspot/share/classfile/classListParser.cpp
> - src/hotspot/share/classfile/classListParser.hpp
> - src/hotspot/share/classfile/classListWriter.hpp
> - src/hotspot/share/classfile/compactHashtable.cpp
> - src/hotspot/share/classfile/compactHashtable.hpp
> - src/hotspot/share/classfile/lambdaFormInvokers.cpp
> - src/hotspot/share/classfile/lambdaFormInvokers.hpp
> - src/hotspot/share/memory/archiveBuilder.cpp
> - src/hotspot/share/memory/archiveBuilder.hpp
> - src/hotspot/share/memory/archiveUtils.cpp
> - src/hotspot/share/memory/archiveUtils.hpp
> - src/hotspot/share/memory/archiveUtils.inline.hpp
> - src/hotspot/share/memory/cppVtables.cpp
> - src/hotspot/share/memory/cppVtables.hpp
> - src/hotspot/share/memory/dumpAllocStats.cpp
> - src/hotspot/share/memory/dumpAllocStats.hpp
> - src/hotspot/share/memory/dynamicArchive.cpp
> - src/hotspot/share/memory/dynamicArchive.hpp
> - src/hotspot/share/memory/filemap.cpp
> - src/hotspot/share/memory/filemap.hpp
> - src/hotspot/share/memory/heapShared.cpp
> - src/hotspot/share/memory/heapShared.hpp
> - src/hotspot/share/memory/heapShared.inline.hpp
> - src/hotspot/share/memory/metaspaceShared.cpp
> - src/hotspot/share/memory/metaspaceShared.hpp
> - src/hotspot/share/prims/cdsoffsets.cpp
> - src/hotspot/share/prims/cdsoffsets.hpp
> 
> Testing with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.

Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:

 - exclude all files under shared/cds if CDS is disabled; compactHashtable.cpp cannot be excluded since a bit of it is used even when CDS is disabled
 - fixed include guards -> #ifndef SHARE_CDS_xxxxx

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3610/files
  - new: https://git.openjdk.java.net/jdk/pull/3610/files/ba45831f..a1a2699f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3610&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3610&range=00-01

  Stats: 66 lines in 19 files changed: 6 ins; 16 del; 44 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3610.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3610/head:pull/3610

PR: https://git.openjdk.java.net/jdk/pull/3610



More information about the build-dev mailing list