RFR: 8265696 move cds sources [v2]
Ioi Lam
iklam at openjdk.java.net
Thu Apr 22 06:23:20 UTC 2021
On Thu, 22 Apr 2021 06:10:17 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> Hi @iklam,
>
> this is a very welcome change!
>
> Nothing much to add to what David wrote (include guards need renaming).
>
> Apart from that, I was surprised that no gtests needed to be adapted, but seems cds has no gtests?
>
> I tested building without cds, works fine.
>
> Thanks for doing this!
>
> If you fix the include guards, this is fine by me.
>
> ..Thomas
Hi Thomas, thanks for the review. You're right that we don't have any gtests .... that should be fixed at some point.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3610
More information about the build-dev
mailing list