RFR: 8265696 move cds sources [v3]

David Holmes dholmes at openjdk.java.net
Thu Apr 22 06:41:33 UTC 2021


On Thu, 22 Apr 2021 06:19:19 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/cds/dynamicArchive.hpp line 38:
>> 
>>> 36: #include "utilities/resourceHash.hpp"
>>> 37: 
>>> 38: #if INCLUDE_CDS
>> 
>> I have to wonder who is including this file and why, if CDS is not enabled.
>
> E.g., jvm.cpp includes dynamicArchive.hpp, but only uses its declarations inside INCLUDE_CDS blocks. It would be too verbose to do this in jvm.cpp
> 
> 
> #if INCLUDE_CDS
> #include "cds/dynamicArchive.hpp"
> #endif

We routinely do that for other INCLUDE_X features.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3610



More information about the build-dev mailing list