RFR: 8269037: jsig/Testjsig.java doesn't have to be restricted to linux only
David Holmes
dholmes at openjdk.java.net
Wed Aug 4 02:21:39 UTC 2021
On Tue, 3 Aug 2021 20:18:11 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
> Hi all,
>
> could you please review this small patch that enables `runtime/jsig/Testjsig.java` test and compilation of its native library on all platforms but windows?
> from JBS:
>> `runtime/jsig/Testjsig.java` test currently `@requires (os.family == "linux")` and `test/hotspot/jtreg/runtime/jsig/libTestJNI.c` compilation is restricted to linux only, however there seems to be nothing in the test code that prevents it from execution on a system that supports POSIX.
>
> testing: `runtime/jsig/Testjsig.java` on `{linux,windows,macosx}-x64`
>
> Thanks,
> -- Igor
Looks good.
Thanks,
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4975
More information about the build-dev
mailing list