RFR: 8273072: Avoid using += in configure [v2]

Magnus Ihse Bursie ihse at openjdk.java.net
Fri Aug 27 13:58:08 UTC 2021


On Fri, 27 Aug 2021 13:15:36 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix code review comments
>
> make/devkit/createMacosxDevkit.sh line 105:
> 
>> 103: 
>> 104: for ex in $EXCLUDE_DIRS; do
>> 105:     EXCLUDE_ARGS="$EXCLUDE_ARGS --exclude=$ex "
> 
> Thanks for your update.
> This copyright should be updated too.

Oh, right... I really need to write a tool that checks that before pushing...

Also, I found out why this actually ever worked. There were a trailing space hidden in the assignment...

-------------

PR: https://git.openjdk.java.net/jdk/pull/5276



More information about the build-dev mailing list