RFR: 8273092: Sort classlist in JDK image [v2]

Ioi Lam iklam at openjdk.java.net
Tue Aug 31 01:05:08 UTC 2021


On Mon, 30 Aug 2021 12:51:43 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @dfuch comments
>
> make/jdk/src/classes/build/tools/classlist/SortClasslist.java line 58:
> 
>> 56:             String line = scanner.nextLine();
>> 57:             Matcher m = p.matcher(line);
>> 58:             if (m.find()) {
> 
> Are we sure that a comment line will not match this regexp, or that if it matches, it is not a comment line?

Thanks for the comments. I've swapper the matching order to check for leading `#` and `@` characters first.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5288



More information about the build-dev mailing list