RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module

[Philip Race]

I can confirm that the autoconf warning disabling is currently still 
needed when building with our standard devkit.

It'll have to be removed at the very end.

In file included from ./open/src/java.security.jgss/macosx/native/libosxkrb5/SCDynamicStoreConfig.m:27:
....
.....

/System/Library/Frameworks/JavaVM.framework/Frameworks/JavaNativeFoundation.framework/Headers/JNFJNI.h:30:
/System/Volumes/Data/mesos/work_dir/jib-master/install/jpg/infra/builddeps/devkit-macosx_x64/System/Library/Frameworks/JavaVM.framework/Frameworks/JavaNativeFoundation.framework/Headers/JNFException.h:49:1: 
error: method has no return type specified; defaults to 'id' 
[-Werror,-Wmissing-method-return-type]
  - init:(JNIEnv *)env throwable:(jthrowable)throwable;
  ^
   (id)
/System/Library/Frameworks/JavaVM.framework/Frameworks/JavaNativeFoundation.framework/Headers/JNFException.h:50:1: 
error: method has no return type specified; defaults to 'id' 
[-Werror,-Wmissing-method-return-type]
  - init:(JNIEnv *)env as:(const char *)javaExceptionType reason:(const 
char *)reasonMsg;
  ^

-phil.

On 2/1/21 8:02 AM, Philip Race wrote:
> Per my comment in the PR I am currently working on updating it to 
> handle the test update needed.
>
> Once the other in-flight PRs are integrated, my grepping says that the 
> only remaining build change
>
> needed after that is to remove one disabled warning in 
> make/autoconf/flags-cflags.m4
>
> I am going to try to find out if we can remove that now or have to 
> wait until all JNF is removed.
>
> FWIW it looks like you added it here : 
> http://hg.openjdk.java.net/jdk/jdk/rev/ec62d6cab037
>
> If we can roll this into an existing PR that might be easier. If it 
> needs to wait for all of them, then we'll play it by ear as to whether 
> to add it fo the last man standing or file a new bug.
>
> -phil
>
> On 2/1/21 3:33 AM, Magnus Ihse Bursie wrote:
>> On 2021-01-29 17:41, Phil Race wrote:
>>> But we can just remove it and prove it - but probably a separate PR 
>>> since it is nothing to do with the desktop module and the autoconf 
>>> code needs to be updated once everything else is in.
>> Fair enough. Do you have a JBS issue tracking the remaining build 
>> system fixes for the JNF removal? I looked around but could not find 
>> one.
>>
>> /Magnus